Add Min(float) and octahedron encode/decode to Vector3.cs #102356
+61
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulsntos
requested changes
Feb 4, 2025
There was a problem hiding this comment.
Thanks, looks great!
It looks like we missed the Vector3.Min method in #80223 (4.3).
Regarding the octahedron methods from #54050 (4.0), I feel like they don't belong in Vector3 but that's where they ended up in Core. The implementation in this PR matches the C++ implementation.
Is there a GodotSharp test suite I can update with these methods?
No, we don't have tests for GodotSharp yet.
a-johnston
force-pushed
the
add_missing_cs_vector_methods
branch
from
e123f85 to
14f7e6f
Compare
raulsntos
added
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few methods which were missing for the cs struct. Is there a GodotSharp test suite I can update with these methods? In lieu of that I manually tested a few 100k random normalized vectors and the values matched between c# and gdscript test scripts 100% of the time.