Implement loading DDS textures at run-time again #101549
Draft
+944
−727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Marcin Nowak <marcin.j.nowak@gmail.com>
|
When you're ready I'll try to review this for Godot Engine 4.5 |
fire
reviewed
Jan 24, 2025
| @@ -77,11 +78,13 @@ class ImageFormatLoaderExtension : public ImageFormatLoader { | |||
| public: | |||
| virtual Error load_image(Ref<Image> p_image, Ref<FileAccess> p_fileaccess, BitField<ImageFormatLoader::LoaderFlags> p_flags = FLAG_NONE, float p_scale = 1.0) override; | |||
| virtual void get_recognized_extensions(List<String> *p_extensions) const override; | |||
| virtual bool should_import(const String &p_resource_type) const override; | |||
There was a problem hiding this comment.
virtual bool should_import(const String &p_resource_type) const override; I think this was added so that Godot Engine can ignore this format loader?
There was a problem hiding this comment.
Yeah with #100538, should_import enables format loaders to designate when they would and would not be ignored by the import process based on the resource type.
There was a problem hiding this comment.
This feels wrong on a gut feeling; I've been ignoring this problem in my other pull request. #101994
|
Reason I have this as a draft is really because I'm waiting on whether anything in #100538 needs any changes, this is practically ready outside that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImageFormatLoaderResource import #100538Adds:
Image::load_dds_from_buffer()Image::load_from_fileAll the DDS layer loading has been moved from texture loader to image loader as handling layers is a little awkward compared to how the other loaders are handled.