Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comments to protect against regressions of accidental memory overwrites. #101385

Closed
wants to merge 1 commit into from
Closed

Add comments to protect against regressions of accidental memory overwrites. #101385

wants to merge 1 commit into from
+6 −0

Conversation

Ivorforce
Copy link
Contributor

@Ivorforce Ivorforce commented Jan 10, 2025 •
edited
Loading

See #31736

The code was not sufficiently commented to protect against regression.

I have recently almost accidentally caused a regression, and now #100944 has almost fallen into the same trap.

@Ivorforce Ivorforce requested a review from a team as a code owner January 10, 2025 11:01
@Ivorforce Ivorforce force-pushed the push-vector-regression branch from 651855f to 815a73f Compare January 10, 2025 11:04
@Ivorforce
Copy link
Contributor Author

Ivorforce commented Jan 10, 2025 •
edited
Loading

It looks like append_array has already regressed.
There should probably be a follow up PR to revert the regression.

@AThousandShips AThousandShips added this to the 4.4 milestone Jan 10, 2025
AThousandShips
AThousandShips approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@Ivorforce Ivorforce mentioned this pull request Jan 10, 2025
Open
@Ivorforce
Copy link
Contributor Author

Superseded by #101386.

@Ivorforce Ivorforce closed this Jan 10, 2025
@AThousandShips AThousandShips removed this from the 4.4 milestone Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
archived enhancement topic:core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ivorforce @AThousandShips