Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editor layout reset on startup #96581

Merged

Conversation

Hilderin
Copy link
Contributor

@Hilderin Hilderin commented Sep 4, 2024

I'm pretty sure it's a regression from #93064. While loading the docks, EditorDockManager::_update_layout calls EditorNode::get_singleton()->save_editor_layout_delayed() before the editor finishes loading the last editor layout. This starts a timer to save the layout after 0.5 seconds. With the addition of a progress dialog in EditorNode::_load_editor_layout, the timer started in save_editor_layout_delayed can now be executed before the editor finishes loading, as the signal can be processed during Main::Iteration.

I added a new global boolean load_editor_layout_done to prevent the editor layout from being saved before it is fully loaded.

@akien-mga akien-mga merged commit d06a10c into godotengine:master Sep 6, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project opens empty sometimes (no open scene and layout is reset)
3 participants