Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--convert-3to4 messes up thread arguments #63292

Closed
and3rson opened this issue Jul 21, 2022 · 1 comment · Fixed by #63887
Closed

--convert-3to4 messes up thread arguments #63292

and3rson opened this issue Jul 21, 2022 · 1 comment · Fixed by #63887

Comments

@and3rson
Copy link
Contributor

and3rson commented Jul 21, 2022

Godot version

4.0-alpha12

System information

ArchLinux

Issue description

# Before --convert-3to4:
thread.start(self, "_load_scene", [map_filename, target_spawn])

# After:
thread.start(self,Callable("_load_scene",[map_filename),target_spawn])

# Expected output:
thread.start(Callable(self, "_load_scene").bind(map_filename, target_spawn))

Steps to reproduce

  1. Create a project in Godot 3.x which uses Thread.new().start with bound parameters
  2. Run Godot 4.x with --convert-3to4
  3. Observe incorrect Callable syntax

Minimal reproduction project

No response

@and3rson and3rson changed the title --convert-2to3 messes up thread arguments --convert-3to4 messes up thread arguments Jul 21, 2022
@Calinou Calinou added this to the 4.0 milestone Jul 21, 2022
@Calinou Calinou moved this to To Assess in 4.x Priority Issues Jul 21, 2022
@Calinou
Copy link
Member

Calinou commented Jul 21, 2022

cc @qarmin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
2 participants