Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG rendering incorrectly after nanosvg update (regression) #43641

Closed
EricEzaM opened this issue Nov 18, 2020 · 3 comments
Closed

SVG rendering incorrectly after nanosvg update (regression) #43641

EricEzaM opened this issue Nov 18, 2020 · 3 comments

Comments

@EricEzaM
Copy link
Contributor

Godot version:
4.0 master f697e78

OS/device including version:
WIN 10

Issue description:
Many (but not all, it seems) SVG icons are rendering incorrectly after f697e78
image

@akien-mga akien-mga added this to the 4.0 milestone Nov 18, 2020
@akien-mga akien-mga self-assigned this Nov 18, 2020
@akien-mga
Copy link
Member

akien-mga commented Nov 18, 2020

I'll bisect the upstream changes.

Edit: Bisected to memononen/nanosvg@e7f5981.

@akien-mga
Copy link
Member

Upstream bug report: memononen/nanosvg#188

@akien-mga
Copy link
Member

Reverted for now until the upstream issue is fixed.

GryphonClaw pushed a commit to GryphonClaw/godot that referenced this issue Nov 19, 2020
This reverts commit f697e78.

Part of the update introduced a regression:
memononen/nanosvg#188.

We could include a local revert of the problematic commit but let's just do a
full revert to our previous version, and I'll re-update once the regression
is fixed upstream.

Fixes godotengine#43641.
akien-mga added a commit to akien-mga/godot that referenced this issue Nov 20, 2020
Includes some loop condition fixes after fuzzing.

The previously identified regression (godotengine#43641) is now fixed upstream.
akien-mga added a commit to akien-mga/godot that referenced this issue Nov 26, 2020
Includes some loop condition fixes after fuzzing.

The previously identified regression (godotengine#43641) is now fixed upstream.

(cherry picked from commit 1bb6491)
HEAVYPOLY pushed a commit to HEAVYPOLY/godot that referenced this issue Dec 14, 2020
Includes some loop condition fixes after fuzzing.

The previously identified regression (godotengine#43641) is now fixed upstream.

(cherry picked from commit 1bb6491)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants