Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhysicsMaterial field exports should be bounded #42202

Closed
rcorre opened this issue Sep 19, 2020 · 0 comments · Fixed by #42203
Closed

PhysicsMaterial field exports should be bounded #42202

rcorre opened this issue Sep 19, 2020 · 0 comments · Fixed by #42203
Labels
bug topic:editor topic:physics
Milestone
4.0

Comments

@rcorre
Copy link
Contributor

rcorre commented Sep 19, 2020

Godot version:

3.2.2.stable.custom_build.bc8eea3e9

OS/device including version:

Linux 5.8.8-arch1-1

Issue description:

The docs for PhysicsMaterial say

float bounce
Default 0.0
The body's bounciness. Values range from 0 (no bounce) to 1 (full bounciness).

float friction
Default 1.0
The body's friction. Values range from 0 (frictionless) to 1 (maximum friction).

However, the editor lets you set any arbitrary value.

1600551544

Steps to reproduce:

Minimal reproduction project:
rcorre added a commit to rcorre/godot that referenced this issue Sep 19, 2020
@rcorre
Fix hints on PhysicsMaterial bounce/friction.
6c18bae 
These values are only meaningful in the range 0 to 1.
Make sure the editor enforces reasonable values.
Fixes godotengine#42202.
@rcorre rcorre mentioned this issue Sep 19, 2020
Merged
@akien-mga akien-mga added this to the 4.0 milestone Sep 23, 2020
akien-mga pushed a commit to akien-mga/godot that referenced this issue Sep 24, 2020
@rcorre @akien-mga
Fix hints on PhysicsMaterial bounce/friction.
c11edbd 
These values are only meaningful in the range 0 to 1.
Make sure the editor enforces reasonable values.
Fixes godotengine#42202.

(cherry picked from commit 6c18bae)
MarcusElg pushed a commit to MarcusElg/godot that referenced this issue Oct 19, 2020
@rcorre @MarcusElg
Fix hints on PhysicsMaterial bounce/friction.
5cfab48 
These values are only meaningful in the range 0 to 1.
Make sure the editor enforces reasonable values.
Fixes godotengine#42202.
@DanielKinsman DanielKinsman mentioned this issue Apr 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic:editor topic:physics
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Fix hints on PhysicsMaterial bounce/friction. rcorre/godot
3 participants
@Calinou @rcorre @akien-mga