Update audio streams page for Godot 4.3 #9522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyace65
added
enhancement
area:manual
|
Thank you so much! I'll review it asap. |
mhilbrunner
approved these changes
Jun 23, 2024
|
gentle reminder poke @adamscott |
|
@mhilbrunner Thanks for the poke. It was needed indeed. |
adamscott
approved these changes
Jun 29, 2024
tutorials/audio/audio_streams.rst
Outdated
Comment on lines
36
to
43
| Playback Type is an experimental setting, and could change in future versions | ||
| of Godot. It exists so web exports use samples for audio instead of streams, | ||
| this prevents the audio from being garbled in single threaded web exports. By | ||
| default only the web platform will use samples, changing this is not recommended | ||
| unless you have an explicit reason to. You can change the default playback type | ||
| for the web and other platforms in the project settings under **Audio > General** | ||
| (advanced settings must be turned on to see the setting). |
There was a problem hiding this comment.
Suggested change
| Playback Type is an experimental setting, and could change in future versions | |
| of Godot. It exists so web exports use samples for audio instead of streams, | |
| this prevents the audio from being garbled in single threaded web exports. By | |
| default only the web platform will use samples, changing this is not recommended | |
| unless you have an explicit reason to. You can change the default playback type | |
| for the web and other platforms in the project settings under **Audio > General** | |
| (advanced settings must be turned on to see the setting). | |
| Playback Type is an experimental setting, and could change in future versions | |
| of Godot. It exists so Web exports use Web Audio-API based samples instead of streaming all sounds to the browser, unlike most platforms. | |
| This prevents the audio from being garbled in single-threaded Web exports. By | |
| default, only the Web platform will use samples. Changing this setting is not recommended, unless you have an explicit reason to. You can change the default playback type | |
| for the web and other platforms in the project settings under **Audio > General** | |
| (advanced settings must be turned on to see the setting). |
mhilbrunner
approved these changes
Jul 1, 2024
|
Thank you, merged, and thanks Adam for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents the new Playback Type property in audio streams (Added in this PR). I've also updated every image on the page for Godot 4.3.