Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update using Skeleton2D documentation #6848

Closed
wants to merge 8 commits into from
Closed

Update using Skeleton2D documentation #6848

wants to merge 8 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 1, 2023

See #6388

I have renamed the cutout animation page to "2D Skeletons" and the 2d skeletons page to "2d Skeletal Deform" and updated the contents of each page accordingly. I cut out the stuff about making bones with sprites because that's not possible anymore.

@mhilbrunner mhilbrunner added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Mar 1, 2023
tutorials/animation/2d_skeletons.rst Outdated Show resolved Hide resolved
@clayjohn
Copy link
Member

I'm not sure the names are very helpful. The Cutout animation tutorial is more about that specific way of animating sprites than it is about using Skeleton2D. The Skeleton2D tutorial, on the other hand, provides much more detail about using the Skeleton2D node.

@ghost
Copy link
Author

ghost commented Mar 17, 2023

So, should I move the information about Skeleton2D from the "2D skeletons" page to the "2d skeletal deform" page?

@fguillen

This comment was marked as off-topic.

Introduction
------------

When working with 3D, skeletal deforms are common for characters and creatures
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes you use the term "skeletal deforms" and sometimes "skeletal deformations". I would prefer "skeletal deformations"

It is also advised to download the final character image
:download:`gBot_complete.png <img/gBot_complete.png>` to have a good reference
for putting the different pieces together.
Create an empty Node2D as root of the scene, we will work under it:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting from here, the names for the bone and sprite nodes are different from the defaults, but there are no instructions to change the name of the nodes. How about

Create an empty Node2D as the root of the scene, and rename it as "GBot". We will work under it:

Head over to the *Points* mode, select the pencil and draw a polygon around the
desired piece:
Continue adding body pieces, starting with the
right arm (your left). Make sure to put each sprite in its correct place in the hierarchy,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 😄


.. image:: img/skel2d3.png
.. image:: img/tutovec_torso1.gif
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image here shows the body bone with a Y position transform not mentioned in the text

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the same illustration as tuto_cutout6.png, and doesn't match the description text.

@myyk
Copy link

myyk commented Jan 8, 2024

Hi, I'm new to Godot (and game dev in general). I was following the docs https://docs.godotengine.org/en/stable/tutorials/animation/cutout_animation.html#doc-cutout-animation and it's really confusing how it's so outdated. None of it's talk about how bones work is correct.

I think an even imperfect version of fixed docs would be much more usable than what's there today. I'd love to see this revived and shipped. I'll try to follow instructions from the .rst files.

@ghost ghost closed this by deleting the head repository Jan 15, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archived area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants