Small edit to quit requests handling #6085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey first edit here, Here's a quick edit for something I just stumbled upon learning Godot 4, basically the notification MainLoop.NOTIFICATION_WM_QUIT_REQUEST changed to NOTIFICATION_WM_CLOSE_REQUEST. Would spare some people quite a bit of confusion I basically had to search through the source's commits since it not only moved but changed name. It *is* already correctly listed in the Node page though. I'm not really sure about the C# code examples though but I doubt it would be more complicated than this.
mhilbrunner
approved these changes
Aug 24, 2022
|
Hi, thanks for contributing and helping others avoid the trouble! 🎉 Congrats on your first contribution to Godot's docs :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey first edit here,
Here's a quick edit for something I just stumbled upon learning Godot 4, basically the notification MainLoop.NOTIFICATION_WM_QUIT_REQUEST changed to NOTIFICATION_WM_CLOSE_REQUEST.
Would spare some people quite a bit of confusion I basically had to search through the source's commits since it not only moved but changed name.
It is already correctly listed in the Node page though.
I'm not really sure about the C# code examples though but I doubt it would be more complicated than this.