Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rainbow bbcode options - add speed #10543

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

havi05
Copy link
Contributor

@havi05 havi05 commented Jan 22, 2025

godotengine/godot#100494 added a new option to the bbcode effect rainbow called speed to fix the animation direction. Updated the documentation to include this.

@skyace65 skyace65 added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Jan 22, 2025
@skyace65 skyace65 merged commit 887c0cc into godotengine:master Jan 22, 2025
1 check passed
@skyace65
Copy link
Contributor

Thanks a ton! We really appreciate it when engine contributors document their PRs

@havi05
Copy link
Contributor Author

havi05 commented Jan 22, 2025

Since the mentioned pr is considered for cherry-picking, do I also have to create pr's for these branches (4.3, 4.2) or will this be done by the maintainers if needed?

Thanks for the kind words!

Edit: Found the answer in the docs.

@tetrapod00
Copy link
Contributor

@havi05 Yeah, you don't need to take any more actions.

To clarify a little more, while the engine PR is marked for cherrypicking, so far it has not been cherrypicked, and therefore the documentation PR isn't marked for cherrypicking. We wouldn't want to document features that don't exist yet. Right now we usually only cherrypick back a single minor version, so there is a chance that the documentation for this feature will only ever exist in the 4.4 and forward version of the documentation, depending on the timing of everything.

@tetrapod00 tetrapod00 added this to the 4.4 milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants