Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document shadowmasks in Using LightmapGI #10482

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Document shadowmasks in Using LightmapGI #10482

merged 1 commit into from
Jan 8, 2025

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jan 7, 2025

@Calinou Calinou mentioned this pull request Jan 7, 2025
Merged
9 tasks
@Calinou Calinou added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.3 labels Jan 7, 2025
@Calinou Calinou force-pushed the using-lightmap-gi-shadowmask branch from eee6b23 to 28a7a0b Compare January 7, 2025 16:11
@SpockBauru
Copy link

Not a native English speaker, but it seems "good enough" for me ^-^

@tetrapod00 tetrapod00 added this to the 4.4 milestone Jan 7, 2025
tetrapod00
tetrapod00 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I trust Calinou on the technical details.

This looks like 4.4 only but let me know if I missed some discussion of cherrypicking in the original PR?

@Calinou
Copy link
Member Author

Calinou commented Jan 7, 2025

This looks like 4.4 only but let me know if I missed some discussion of cherrypicking in the original PR?

Yes, it's 4.4-only.

@mhilbrunner mhilbrunner merged commit 4ffef4f into godotengine:master Jan 8, 2025
1 check passed
@mhilbrunner
Copy link
Member

Thanks!

@Calinou Calinou deleted the using-lightmap-gi-shadowmask branch January 8, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tetrapod00 tetrapod00 tetrapod00 approved these changes

@mhilbrunner mhilbrunner mhilbrunner approved these changes

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:rendering topic:3d
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@Calinou @SpockBauru @mhilbrunner @tetrapod00