Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the "Example lobby implementation" section of the High-level multiplayer tutorial #10481

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Fix the "Example lobby implementation" section of the High-level multiplayer tutorial #10481

merged 1 commit into from
Jan 8, 2025

Conversation

mateuseap
Copy link
Contributor

@mateuseap mateuseap commented Jan 7, 2025 •
edited
Loading

Closes #10367

What I Did

@mateuseap
Fix the "Example lobby implementation" section of the High-level mult…
d0e6217 
…iplayer tutorial

Correct both the GDScript and C# code examples in the "Example lobby implementation" section of the Networking/High-level multiplayer tutorial.
@tetrapod00 tetrapod00 added area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:network topic:multiplayer cherrypick:4.3 labels Jan 7, 2025
@mhilbrunner mhilbrunner merged commit d8fecf7 into godotengine:master Jan 8, 2025
1 check passed
@mhilbrunner
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.3 topic:multiplayer topic:network
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing players.clear() inside the remove_multiplayer_peer of the example lobby implementation
3 participants
@mateuseap @mhilbrunner @tetrapod00