Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binding generator cleanups #977

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Binding generator cleanups #977

merged 1 commit into from
Jan 30, 2023

Conversation

asmaloney
Copy link
Contributor

@asmaloney asmaloney commented Dec 26, 2022 •
edited
Loading

  • remove unused vars
  • fix a few f-strings
  • remove f-string notation where not used

@asmaloney asmaloney requested a review from a team as a code owner December 26, 2022 18:49
@akien-mga
Copy link
Member

"virtual" on an overridden method is redundant

That's true, but currently our convention in the main Godot codebase is to use both. virtual + override communicates clearly that it's overriding an inherited virtual method, and can be overridden further in a derived class (which is indeed implicit in override, but the virtual prefix is arguably easier to spot when reader a header).

@akien-mga akien-mga added the enhancement This is an enhancement on the current functionality label Jan 30, 2023
@asmaloney
Binding generator cleanups
2d5e5c0 
- remove unused vars
- fix a few f-strings
- remove f-string notation where not used
@akien-mga akien-mga merged commit 552f138 into godotengine:master Jan 30, 2023
@asmaloney asmaloney deleted the binding-cleanup branch January 30, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement This is an enhancement on the current functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asmaloney @akien-mga