Rename godot-headers to gdextension, move header to top folder #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
breaks compat
topic:buildsystem
Changes the `<godot/gdextension_interface.h>` include to simply `<gdextension_interface.h>`. Refactor and better document the SCons and CMake logic around setting the paths to the header and API JSON file.
akien-mga
force-pushed
the
godot-headers-is-dead-long-live-godot-headers
branch
from
1b5bfe3 to
bab247d
Compare
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Dec 14, 2022
Follow-up to godotengine/godot-cpp#960. Fix exit code for --dump-extension-api and --dump-gdextension-interface. Removed the planned API validation step as we still didn't implement anything, and maintaining a stub isn't useful.
rohanrhu
pushed a commit
to rohanrhu/godot
that referenced
this pull request
Dec 28, 2022
Follow-up to godotengine/godot-cpp#960. Fix exit code for --dump-extension-api and --dump-gdextension-interface. Removed the planned API validation step as we still didn't implement anything, and maintaining a stub isn't useful.
rohanrhu
pushed a commit
to rohanrhu/godot
that referenced
this pull request
Dec 28, 2022
Follow-up to godotengine/godot-cpp#960. Fix exit code for --dump-extension-api and --dump-gdextension-interface. Removed the planned API validation step as we still didn't implement anything, and maintaining a stub isn't useful.
Streq
pushed a commit
to Streq/godot
that referenced
this pull request
Feb 9, 2023
Follow-up to godotengine/godot-cpp#960. Fix exit code for --dump-extension-api and --dump-gdextension-interface. Removed the planned API validation step as we still didn't implement anything, and maintaining a stub isn't useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
<godot/gdextension_interface.h>include to simply<gdextension_interface.h>.Refactor and better document the SCons and CMake logic around setting the paths to the header and API JSON file.