Fix virtual GDExtension method Ref<T> conversion #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastiaanOlij
added
the
enhancement
BastiaanOlij
force-pushed
the
improve_gdextension_virtual_ref
branch
from
fa99cbe to
3b911f7
Compare
Closed
BastiaanOlij
force-pushed
the
improve_gdextension_virtual_ref
branch
from
3b911f7 to
27e7d56
Compare
BastiaanOlij
force-pushed
the
improve_gdextension_virtual_ref
branch
from
27e7d56 to
992d85e
Compare
akien-mga
approved these changes
Dec 14, 2022
|
Thanks! |
This was referenced Dec 15, 2022
Closed
79 tasks
This was referenced Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The godot-cpp side of godotengine/godot#69902
This uses the two new functions introduced in Godot so we can properly handle Godot supplied
Ref<T>pointers and get/set our objects.