Object::cast_to checks provided object for nullptr #794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
Objec::cast_to
is merely a dynamic_cast, it shouldn't fail onnullptr
. As the provided argument gets dereferenced right away, we have to make the initial check. As I'm fairly new to the godot scene, I do not have much insights into the code base. Perhaps there is a more elegant solution to the problem, but I won't find it right now.Nevertheless, this fix also fixes calls to
Node::get_node<T>
when noNode
with the given name can be found (and probably even more other parts).