SCons: Default num_jobs to max CPUs minus 1 if not specified
#788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
enhancement
This doesn't change the behavior when `--jobs`/`-j` is specified as a command-line argument or in `SCONSFLAGS`. The SCons hack used to know if `num_jobs` was set by the user is derived from the MongoDB setup. We use `os.cpu_count()` for portability (available since Python 3.4). With 4 CPUs or less, we use the max. With more than 4 we use max - 1 to preserve some bandwidth for the user's other programs.
akien-mga
force-pushed
the
scons-num_jobs-default-max
branch
from
aaceb27 to
cdcd473
Compare
bruvzg
approved these changes
Jul 17, 2022
Actually I had missed |
|
Cherry-picked for 3.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't change the behavior when
--jobs/-jis specified as acommand-line argument or in
SCONSFLAGS.The SCons hack used to know if
num_jobswas set by the user is derivedfrom the MongoDB setup.
We use
os.cpu_count()for portability (available since Python 3.4).With 4 CPUs or less, we use the max. With more than 4 we use max - 1 to
preserve some bandwidth for the user's other programs.
Equivalent to upstream Godot godotengine/godot#63087.
Should speed up macOS builds by using 3 cores by default (and dehardcodes
-j4in the Makefile).