Fix GDN_EXPORT define with mingw. #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faless
added
bug
Faless
force-pushed
the
fix/4.x_mingw_export
branch
from
60942a0 to
5bbcd42
Compare
This commit changes the platform detection order to detect mingw compiling for windows (which defines `__GNUC__`). This commit also wraps the definition around a guard so it can be overridden via a define at build-time.
akien-mga
approved these changes
Jun 27, 2022
|
Thanks! |
|
Just a note to self, I wonder for a bit if this had/should be cherry-picked for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the platform detection order to detect mingw compiling for windows (which defines
__GNUC__).This commit also wraps the definition around a guard so it can be overridden via a define at build-time.
Refs: godotengine/godot#62173 #673 , #468 (?), godotengine/webrtc-native#52 .