Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix install scoop on Windows #722

Closed
wants to merge 1 commit into from
Closed

Conversation

akien-mga
Copy link
Member

It now requires the -RunAsAdmin argument.

@akien-mga akien-mga added bug This has been identified as a bug platform:windows topic:buildsystem Related to the buildsystem or CI setup cherrypick:3.4 cherrypick:3.x labels Mar 9, 2022
@akien-mga akien-mga force-pushed the ci-scoop-RunAsAdmin branch 2 times, most recently from 51fcb62 to 7048d6e Compare March 9, 2022 12:10
It now requires the `-RunAsAdmin` argument.
@akien-mga akien-mga force-pushed the ci-scoop-RunAsAdmin branch from 7048d6e to 3012dff Compare March 9, 2022 12:13
@akien-mga
Copy link
Member Author

Superseded by #723.

@akien-mga akien-mga closed this Mar 9, 2022
@akien-mga akien-mga deleted the ci-scoop-RunAsAdmin branch March 9, 2022 12:36
# Install GCC from Scoop as the default supplied GCC doesn't work ("Error 1").
run: |
Set-ExecutionPolicy RemoteSigned -scope CurrentUser
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's used to allow unsigned script execution, not to set current user. It won't help here.

Something like this might work:

Invoke-Command -ScriptBlock ([ScriptBlock]::Create((New-Object System.Net.WebClient).DownloadString('https://get.scoop.sh'))) -ArgumentList RunAsAdmin

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't like PowerShell syntax so I went for a more radical approach :P #723

That action seems to use Chocolatey behind the scenes so it's pretty similar in the end, but looks a tiny bit cleaner on our side.

@akien-mga akien-mga modified the milestone: 4.0 Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archived bug This has been identified as a bug platform:windows topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants