Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GDCLASS when inherited class is in another namespace #708

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Fix GDCLASS when inherited class is in another namespace #708

merged 1 commit into from
Feb 21, 2022

Conversation

Zylann
Copy link
Collaborator

@Zylann Zylann commented Feb 20, 2022 •
edited
Loading

Fixes #694

Note: the binding generator already does this:

godot-cpp/binding_generator.py

Line 925 in 4d9fe6d

inherits = class_api["inherits"] if "inherits" in class_api else "Wrapped"

@Zylann Zylann force-pushed the fix_inheriting_class_with_namespace branch from 1b7a1e1 to 3c4afa7 Compare February 20, 2022 19:31
@Zylann Zylann force-pushed the fix_inheriting_class_with_namespace branch from 3c4afa7 to 6fdcb18 Compare February 20, 2022 19:33
@Calinou Calinou added bug This has been identified as a bug topic:gdextension This relates to the new Godot 4 extension implementation labels Feb 20, 2022
@akien-mga akien-mga merged commit d154ffb into godotengine:master Feb 21, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga added this to the 4.0 milestone Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug This has been identified as a bug topic:gdextension This relates to the new Godot 4 extension implementation
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Using namespace in GDCLASS macro prevents new node type from appearing in editor
3 participants
@Zylann @akien-mga @Calinou