Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Fix exposed suffix, remove unused option. #690

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

Faless
Copy link
Contributor

@Faless Faless commented Feb 10, 2022

Follow up on #636 which resulted in the test library being produced with the wrong name (missing dot).

@Faless Faless added the bug This has been identified as a bug label Feb 10, 2022
@Faless Faless added this to the 4.0 milestone Feb 10, 2022
@Faless Faless added the topic:buildsystem Related to the buildsystem or CI setup label Feb 10, 2022
@Faless Faless marked this pull request as draft February 10, 2022 05:10
@Faless
Copy link
Contributor Author

Faless commented Feb 10, 2022

Might also need a small fix for iOS simulator, will confirm soon.

@Faless Faless marked this pull request as ready for review February 10, 2022 06:36
@Faless
Copy link
Contributor Author

Faless commented Feb 10, 2022

Added fix for ios simulator.

@akien-mga akien-mga merged commit 63531a8 into godotengine:master Feb 10, 2022
@akien-mga
Copy link
Member

Thanks!

@Faless Faless deleted the build/fix_suffix branch February 10, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This has been identified as a bug topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants