Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Vector3::operator Vector3i definition #688

Merged
merged 2 commits into from
Feb 19, 2022
Merged

Add missing Vector3::operator Vector3i definition #688

merged 2 commits into from
Feb 19, 2022

Conversation

zhehangd
Copy link
Contributor

@zhehangd zhehangd commented Feb 7, 2022

The definition is simply missing.

@akien-mga akien-mga added the bug This has been identified as a bug label Feb 7, 2022
@akien-mga
Copy link
Member

The matching Vector2i operator seems to be missing in vector2.cpp too, could you add that too?

@zhehangd
Copy link
Contributor Author

zhehangd commented Feb 7, 2022

Done. Btw I notice there is no veci to vec conversion, is that intentional?

@zhehangd zhehangd requested a review from akien-mga February 18, 2022 18:01
@akien-mga
Copy link
Member

Btw I notice there is no veci to vec conversion, is that intentional?

This could be added, though I see it also needs to be added in godotengine/godot for Vector3i.

@akien-mga akien-mga merged commit 917b0c2 into godotengine:master Feb 19, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Btw I notice there is no veci to vec conversion, is that intentional?

This could be added, though I see it also needs to be added in godotengine/godot for Vector3i.

Done in #707.

@akien-mga akien-mga added this to the 4.0 milestone Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This has been identified as a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants