Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print a warning with unknown SCons variables to ease troubleshooting #661

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Print a warning with unknown SCons variables to ease troubleshooting #661

merged 1 commit into from
Nov 24, 2021

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Nov 23, 2021 •
edited
Loading

Follow-up to godotengine/godot#55203.

Preview

❯ scons example=no  
scons: Reading SConscript files ...
WARNING: Unknown SCons variables were passed and will be ignored:
    example=no
scons: done reading SConscript files.
scons: Building targets ...

@Calinou Calinou added enhancement This is an enhancement on the current functionality cherrypick:3.4 cherrypick:3.x labels Nov 23, 2021
BastiaanOlij
BastiaanOlij approved these changes Nov 24, 2021
View reviewed changes
Copy link
Collaborator

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@akien-mga akien-mga merged commit d619c61 into godotengine:master Nov 24, 2021
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the scons-warn-unknown-variables branch November 24, 2021 15:32
@akien-mga
Copy link
Member

Cherry-picked for 3.x and 3.4.

@akien-mga akien-mga added this to the 4.0 milestone Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@BastiaanOlij BastiaanOlij BastiaanOlij approved these changes

Assignees
No one assigned
Labels
enhancement This is an enhancement on the current functionality
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Calinou @akien-mga @BastiaanOlij