Add pointers support for virtual methods. #625
Conversation
Faless
added
enhancement
As introduced in godot for virtual methods. Custom structs are not yet supported.
Faless
force-pushed
the
ext/pointers
branch
from
bf1bf78 to
80fdb91
Compare
| @@ -184,6 +184,47 @@ struct PtrToArg<const T *> { | |||
| } | |||
| }; | |||
|
|
|||
| // Pointers. | |||
There was a problem hiding this comment.
Maybe add a comment that this should be kept in sync with https://github.com/godotengine/godot/blob/master/core/variant/native_ptr.h (especially the GDVIRTUAL_NATIVE_PTR calls).
| GDVIRTUAL_NATIVE_PTR(char32_t); | ||
| GDVIRTUAL_NATIVE_PTR(wchar_t); | ||
| GDVIRTUAL_NATIVE_PTR(uint8_t); | ||
| GDVIRTUAL_NATIVE_PTR(uint8_t *); |
There was a problem hiding this comment.
Comparing with https://github.com/godotengine/godot/blob/master/core/variant/native_ptr.h, this one seems unique here. Is that expected?
Also AudioFrame missing but I guess that's what you meant with "Custom structs are not yet supported."
There was a problem hiding this comment.
Comparing with https://github.com/godotengine/godot/blob/master/core/variant/native_ptr.h, this one seems unique here. Is that expected?
Oh I haven't yet merged godotengine/godot#52481 , that's the PacketPeer uint8_t **, hence the GDVIRTUAL_NATIVE_PTR(uint8_t *);
Also
AudioFramemissing but I guess that's what you meant with "Custom structs are not yet supported."
Yes, those should be auto-generated
As introduced in godot for virtual methods.
Custom structs are not yet supported.