Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SCons variant_dir support #1669

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add SCons variant_dir support #1669

wants to merge 1 commit into from
+36 −21

Conversation

Ivorforce
Copy link
Contributor

@Ivorforce Ivorforce commented Dec 10, 2024 •
edited
Loading

Supersedes #1439 - it's basically just a rebase. It compiles, but I haven't checked if it does what it says it does (allow godot-cpp to be included from elsewhere).

@Ivorforce Ivorforce requested a review from a team as a code owner December 10, 2024 15:02
Ivorforce
Ivorforce commented Dec 10, 2024
View reviewed changes
Copy link
Contributor Author

@Ivorforce Ivorforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting "my own" PR because so far I've only rebased. Would like to see if anybody has comments on my comments, otherwise I'll probably just adjust things as I see fet.

tools/godotcpp.py Outdated Show resolved Hide resolved
tools/godotcpp.py Outdated Show resolved Hide resolved
tools/godotcpp.py Outdated Show resolved Hide resolved
@Ivorforce Ivorforce force-pushed the scons-variant_dir-support branch 5 times, most recently from 537328b to 55e93ea Compare December 18, 2024 14:04
@Ivorforce
Copy link
Contributor Author

Alright, code wise, I think this is ready now.
I still haven't tested it though. Someone should probably do that before a merge (i may, but it may take a few more days).

Faless
Faless reviewed Jan 12, 2025
View reviewed changes
tools/godotcpp.py Outdated Show resolved Hide resolved
@dsnopek dsnopek added enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup labels Jan 12, 2025
@dsnopek dsnopek added this to the 4.x milestone Jan 12, 2025
@Ivorforce Ivorforce force-pushed the scons-variant_dir-support branch 2 times, most recently from 3078526 to f60cac5 Compare January 12, 2025 16:51
@Ivorforce Ivorforce force-pushed the scons-variant_dir-support branch from f60cac5 to 1345c46 Compare January 12, 2025 17:33
@Ivorforce
Copy link
Contributor Author

Ivorforce commented Jan 29, 2025 •
edited
Loading

Alright, I tested this, it seems to work.

To use it, one has to call SConscript like env = SConscript("../SConstruct", variant_dir="build_folder"). I tested this from the test project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Faless Faless Faless left review comments

Assignees
No one assigned
Labels
enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
Milestone
4.x
Development

Successfully merging this pull request may close these issues.
4 participants
@Ivorforce @Faless @dsnopek @Cedev