Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extension support for argument count to ScriptInstance #1413

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Add extension support for argument count to ScriptInstance #1413

merged 1 commit into from
Apr 2, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips added enhancement This is an enhancement on the current functionality waiting for Godot This issue needs a Godot Engine improvement to be solved topic:gdextension This relates to the new Godot 4 extension implementation labels Mar 14, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Mar 14, 2024
@AThousandShips AThousandShips removed the waiting for Godot This issue needs a Godot Engine improvement to be solved label Mar 14, 2024
@AThousandShips AThousandShips marked this pull request as ready for review March 14, 2024 21:38
@AThousandShips AThousandShips requested a review from a team as a code owner March 14, 2024 21:38
dsnopek
dsnopek approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsnopek dsnopek merged commit 3715bfe into godotengine:master Apr 2, 2024
12 checks passed
@AThousandShips
Copy link
Member Author

Thank you!

@AThousandShips AThousandShips deleted the the_angry_count_extended_cpp branch April 2, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

Assignees
No one assigned
Labels
enhancement This is an enhancement on the current functionality topic:gdextension This relates to the new Godot 4 extension implementation
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@AThousandShips @dsnopek