-
-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing OP_POWER
operator to Variant
#1349
Conversation
Hi @AThousandShips I can confirm this will be okay in its current form and it does fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Assuming I'm understanding this right, currently Variant::evaluate()
is broken with all operators after OP_POWER
because missing that item means the enum in godot-cpp doesn't line up with the enum in the GDExtension interface.
In any case, this change looks great to me :-)
Thanks! |
Thank you! |
Yep, thanks! |
Cherry-picking to 4.2 in #1372 |
Cherry-picking to 4.1 in #1373 |
I don't think this breaks compatibility as there's no binary compatibility to maintain here, the mapping to the engine is done via the interface macros, but need verification here
Edit: This likely fixes
Variant::evaluate
which tries to mapOperator
toGDExtensionVariantOperator
which doesn't line up