Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-picks for the godot-cpp 4.1 branch - 2nd batch #1227

Merged
merged 10 commits into from
Sep 2, 2023
Merged

Cherry-picks for the godot-cpp 4.1 branch - 2nd batch #1227

merged 10 commits into from
Sep 2, 2023

Conversation

dsnopek
Copy link
Collaborator

@dsnopek dsnopek commented Sep 1, 2023

The 2nd batch of PR's marked with cherrypick:4.1

Zylann and others added 10 commits September 1, 2023 17:06
@Zylann @dsnopek
Added generated version header
0f2d365 
(cherry picked from commit c6b2c82)
@dsnopek
Add automated tests to verify some previous fixes
960c906 
(cherry picked from commit d5fab0b)
@adamscott @dsnopek
Fix Clang deprecated builtins
6789b29 
It seems that Clang and GCC have different interpretations of certain
builtins. So this PR uses std <type_traits> functions just as cowdata.h
does in the godot project.

(cherry picked from commit 5c26284)
@adamscott @dsnopek
Fix forgotten not operator
c7afd0f 
(cherry picked from commit f5c8e51)
@akien-mga @dsnopek
SCons: Sync targets.py fully with upstream Godot
738ef9b 
- Reorders existing code to match Godot.
- Adds `NDEBUG` for non-dev builds.
- Adds `-gdwarf-4` for Clang debug symbols.
- Adds strip link flag for GCC/Clang builds without debug symbols.

(cherry picked from commit 600e749)
@AThousandShips @dsnopek
Add remaining component-wise min/max functions to Vector*
170a691 
(cherry picked from commit 52eb77e)
@AThousandShips @dsnopek
Fix link to test project in readme
c6fe653 
Also updated format for library paths

(cherry picked from commit e586e11)
@dsnopek
Clarify versions and examples in the README
ce5dd37 
(cherry picked from commit 1588dc8)
@Faless @dsnopek
[SCons] Move the GodotCPP build to its own tool.
63755b2 
(cherry picked from commit f8b4f60)
@AThousandShips @dsnopek
Fix formatting of compatibility_minimum examples
c3771fb 
Without quotes the values is parsed as a float, breaking in various
cases.

(cherry picked from commit b3596a1)
@dsnopek dsnopek added bug This has been identified as a bug enhancement This is an enhancement on the current functionality labels Sep 1, 2023
@dsnopek dsnopek requested a review from a team as a code owner September 1, 2023 22:12
@dsnopek dsnopek mentioned this pull request Sep 1, 2023
Merged
akien-mga
akien-mga approved these changes Sep 2, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dsnopek dsnopek merged commit bc980b5 into godotengine:4.1 Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug This has been identified as a bug enhancement This is an enhancement on the current functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dsnopek @akien-mga @Zylann @adamscott @AThousandShips @Faless