SCons: Sync targets.py fully with upstream Godot
#1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
enhancement
- Reorders existing code to match Godot. - Adds `NDEBUG` for non-dev builds. - Adds `-gdwarf-4` for Clang debug symbols. - Adds strip link flag for GCC/Clang builds without debug symbols.
akien-mga
force-pushed
the
scons-targets-sync-with-godot
branch
from
dac4c7b to
600e749
Compare
dsnopek
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Thanks!
I can't speak so much for the functionality of what the changes do here, but this does look like a faithful copy-paste of the Godot code with only minor modifications:
env_base->env- The addition of the
DEBUG_METHODS_ENABLEDdefine using_clang(env)->methods.using_clang(env)and the same foris_vanilla_clang()
And since it successfully built for the all the platforms on CI, I think we can say it probably didn't break anything.
bruvzg
approved these changes
Aug 16, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NDEBUGfor non-dev builds.-gdwarf-4for Clang debug symbols.Follow-up to #1203.
The additions are up to discussion, if some seem unwanted in the context of GDExtension, I can remove them and document why we differ from upstream.
This syncs with:
https://github.com/godotengine/godot/blob/013e8e3afb982d4b230f0039b6dc248b48794ab9/SConstruct#L402-L437
and:
https://github.com/godotengine/godot/blob/013e8e3afb982d4b230f0039b6dc248b48794ab9/SConstruct#L574-L619