-
-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remaining component-wise min/max
functions to Vector*
#1197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! The implementations match their Godot counterparts.
Since this doesn't rely on the Godot PR, I think it'd be fine to merge this even before that PR is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These new functions look good to me.
e911065
to
52eb77e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
godotengine/godot#73265 probably should be ported as well.
Or maybe we can mod the engine files (math types and templates) to be buildable in both godot-cpp
and the engine (similar to the TextServer
s) and sync them by just copying files as is.
Thanks!
I think we can address/explore those in follow-up PRs |
Thank you! |
Vector*
component-wise and scalarmin/max
to scripting godot#80223