Add platform macros

[adamscott]

Add platform macros, like LINUX_ENABLED and UNIX_ENABLED on Linux, MACOS_ENABLED, UNIX_ENABLED, COREAUDIO_ENABLED, COREMIDI_ENABLED on macos, and WINDOWS_ENABLED, WASAPI_ENABLED, WINMIDI_ENABLED on Windows.

[dsnopek]

Thanks! I haven't had a chance to do a proper review yet, but I think this is a great idea

[Faless]

Please move the flags to the dedicated platform tools in tools, inside the generate function.
These are the "equivalent" of upstream Godot configure functions inside platform/name/detect.py:

• tools/windows.py
• tools/linux.py
• tools/macos.py
• tools/ios.py
• etc.

This will also simplify the code as you can just add the flags there without having to check for the env["platform"] variables (the generate function is called only when the given platform is selected).

[adamscott]

Please move the flags to the dedicated platform tools in tools, inside the generate function.

Yes, I saw this yesterday, but didn't have time to change it. Thanks, will do.

[Faless]

See my 2 comments, I will open a separate PR to merge the osxcross tools and reduce confusion.

[Faless]

This looks good now 👍 .
The only thing I'm not sure about is having COREAUDIO_ENABLED, COREMIDI_ENABLED on ios/macos, and WASAPI_ENABLED, WINMIDI_ENABLED on windows.

Why are they useful? I think those are there to control godot driver internals, and if they can't be disabled on those platforms, then extensions could just check for WINDOWS_ENABLED/MACOS_ENABLED.

[adamscott]

@Faless I just removed the non-platform related macros!

[dsnopek]

Thanks!

This looks great to me. I did a quick test, and I can see the Linux defines showing up as expected.