Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #1127 by making return types of auto-generated functions dynamic #1128

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

Mathis-Z
Copy link
Contributor

This should fix #1127 by changing the type of the return variable to match the actual type of the returned value.

@Mathis-Z Mathis-Z requested a review from a team as a code owner May 30, 2023 20:37
@dsnopek dsnopek added the bug This has been identified as a bug label May 31, 2023
@dsnopek
Copy link
Collaborator

dsnopek commented Jun 8, 2023

Thanks!

This works in my testing and the fix looks right to me.

I've attached a patch which adds an automated test to validate the fix: it fails without it, and then passes with it. Feel free to integrate this into your PR if you'd like! Otherwise, I'll make a follow-up PR afterward :-)

str-utility-test.txt

@akien-mga akien-mga added this to the 4.1 milestone Jun 8, 2023
@Mathis-Z
Copy link
Contributor Author

Mathis-Z commented Jun 8, 2023

I added your test case. Should be good to merge now.

@dsnopek
Copy link
Collaborator

dsnopek commented Jun 8, 2023

Thanks!

However, per Godot's pull request workflow, in order for this to be merged you'll need to squash the changes into a single commit:

https://docs.godotengine.org/en/stable/contributing/workflow/pr_workflow.html#the-interactive-rebase

@Mathis-Z
Copy link
Contributor Author

Mathis-Z commented Jun 8, 2023

Sorry, I did not catch that.

@akien-mga akien-mga merged commit d12cf07 into godotengine:master Jun 8, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This has been identified as a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UtilityFunctions::str_internal always crashes
3 participants