-
-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Getting Started section of README.md #1115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks for catching that! This looks good to me :-)
Docs part of godotengine/godot-cpp#1095 Same changes as godotengine/godot-cpp#1115
Docs part of godotengine/godot-cpp#1095 Same changes as godotengine/godot-cpp#1115
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as well! Nice catch!
Docs part of godotengine/godot-cpp#1095 Same changes as godotengine/godot-cpp#1115
This should update the note at the top of the README to say that |
Good call, I've updated the warning to clarify that the current version on |
@dgcole This needs a squash to be merged. |
This document is helpful for squashing your commits into a single one: https://docs.godotengine.org/en/stable/contributing/workflow/pr_workflow.html#the-interactive-rebase There also appears to be a "coding standards" failure in CI: https://github.com/godotengine/godot-cpp/actions/runs/5060252047/jobs/9087748389?pr=1115 It looks like a trailing space at the end of this line:
|
Thanks! |
Not sure if there is any procedure for PRs on this repo / template that I am missing, hopefully not.
When updating, I noticed that the implementation of the demo extension was changed with #1095 , but the corresponding README.md sections were not updated, so I figured I might as well make a PR.