Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Getting Started section of README.md #1115

Merged
merged 1 commit into from
May 25, 2023

Conversation

dgcole
Copy link
Contributor

@dgcole dgcole commented May 17, 2023

Not sure if there is any procedure for PRs on this repo / template that I am missing, hopefully not.

When updating, I noticed that the implementation of the demo extension was changed with #1095 , but the corresponding README.md sections were not updated, so I figured I might as well make a PR.

@dgcole dgcole requested a review from a team as a code owner May 17, 2023 03:15
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks for catching that! This looks good to me :-)

paddy-exe added a commit to paddy-exe/godot-docs that referenced this pull request May 18, 2023
paddy-exe added a commit to paddy-exe/godot-docs that referenced this pull request May 18, 2023
@paddy-exe paddy-exe added documentation topic:gdextension This relates to the new Godot 4 extension implementation labels May 18, 2023
Copy link
Contributor

@paddy-exe paddy-exe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well! Nice catch!

paddy-exe added a commit to paddy-exe/godot-docs that referenced this pull request May 19, 2023
@mhilbrunner
Copy link
Member

This should update the note at the top of the README to say that master is 4.1+ and to include 4.0 in the branches mentioned people may want to check out. Otherwise looks good to me.

@dgcole
Copy link
Contributor Author

dgcole commented May 23, 2023

This should update the note at the top of the README to say that master is 4.1+ and to include 4.0 in the branches mentioned people may want to check out. Otherwise looks good to me.

Good call, I've updated the warning to clarify that the current version on master is for 4.1+, and I added a note to switch to 4.0 for 4.0.x versions of the engine.

@paddy-exe
Copy link
Contributor

@dgcole This needs a squash to be merged.

@dsnopek
Copy link
Collaborator

dsnopek commented May 24, 2023

This document is helpful for squashing your commits into a single one:

https://docs.godotengine.org/en/stable/contributing/workflow/pr_workflow.html#the-interactive-rebase

There also appears to be a "coding standards" failure in CI: https://github.com/godotengine/godot-cpp/actions/runs/5060252047/jobs/9087748389?pr=1115

It looks like a trailing space at the end of this line:

> This repository's `master` branch is only usable with the latest version of 

@dsnopek dsnopek merged commit 08bc2ef into godotengine:master May 25, 2023
@dsnopek
Copy link
Collaborator

dsnopek commented May 25, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation topic:gdextension This relates to the new Godot 4 extension implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants