Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExampleRef::get_id() should be const #1030

Merged
merged 1 commit into from
Feb 7, 2023
Merged

ExampleRef::get_id() should be const #1030

merged 1 commit into from
Feb 7, 2023

Conversation

asmaloney
Copy link
Contributor

No description provided.

@asmaloney asmaloney requested a review from a team as a code owner February 2, 2023 18:01
bruvzg
bruvzg approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not change anything, but I guess more correct.

touilleMan
touilleMan approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@touilleMan touilleMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmaloney
Copy link
Contributor Author

Does not change anything, but I guess more correct.

People are learning from these examples so I feel they should at least be decent code 😄

@akien-mga akien-mga added the enhancement This is an enhancement on the current functionality label Feb 7, 2023
@akien-mga akien-mga merged commit 9607a51 into godotengine:master Feb 7, 2023
@akien-mga
Copy link
Member

Thanks!

@asmaloney asmaloney deleted the constify branch February 7, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg approved these changes

@touilleMan touilleMan touilleMan approved these changes

Assignees
No one assigned
Labels
enhancement This is an enhancement on the current functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asmaloney @akien-mga @touilleMan @bruvzg