Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{cmake} Add GODOT_CPP_SYSTEM_HEADERS option to mark includes as SYSTEM #1002

Merged
merged 1 commit into from
Jan 19, 2023
Merged

{cmake} Add GODOT_CPP_SYSTEM_HEADERS option to mark includes as SYSTEM #1002

merged 1 commit into from
Jan 19, 2023

Conversation

asmaloney
Copy link
Contributor

From the cmake docs:

This may have effects such as suppressing warnings or skipping the contained headers in dependency calculations (see compiler documentation). Additionally, system include directories are searched after normal include directories regardless of the order specified.

Addresses part of #999

@asmaloney
{cmake} Add GODOT_CPP_SYSTEM_HEADERS option to mark includes as SYSTEM
1351710 
From the cmake docs:

"This may have effects such as suppressing warnings or skipping the contained headers in dependency calculations (see compiler documentation). Additionally, system include directories are searched after normal include directories regardless of the order specified."

Addresses part of godotengine#999
@asmaloney asmaloney requested a review from a team as a code owner January 19, 2023 02:16
@akien-mga akien-mga added enhancement This is an enhancement on the current functionality cmake topic:buildsystem Related to the buildsystem or CI setup labels Jan 19, 2023
@akien-mga akien-mga merged commit 952bde1 into godotengine:master Jan 19, 2023
@akien-mga
Copy link
Member

Thanks!

@asmaloney asmaloney deleted the cmake-system-includes branch January 19, 2023 12:59
@asmaloney asmaloney restored the cmake-system-includes branch January 19, 2023 12:59
@asmaloney asmaloney deleted the cmake-system-includes branch January 19, 2023 12:59
@Faless Faless mentioned this pull request Jan 19, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
cmake enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asmaloney @akien-mga