-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass-by-ref for non-Copy
builtins (frontend)
#900
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-900 |
f1cfa06
to
2a13c68
Compare
2a13c68
to
5a626c5
Compare
Copy
builtinsCopy
builtins (frontend)
Merging, as there's a sizeable amount of changes already. The "backend" changes (actual FFI passing) as well as fine-tuning the APIs like |
This was referenced Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-change
Requires SemVer bump
c: engine
Godot classes (nodes, resources, ...)
c: ffi
Low-level components and interaction with GDExtension API
feature
Adds functionality to the library
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables several builtins that don't implement
Copy
to be passed by reference (borrowed) into engine APIs. Examples areArray
,Packed*Array
,Dictionary
,Variant
.This lays the groundwork for future optimizations which exploit borrowing to avoid unnecessary cloning/ref-count operations, thus further reducing API call overhead.
There are some ergonomic impacts of requiring
&
in more places, however on the other side.clone()
calls can often be avoided now. The current draft uses theBorrow
trait in a few manual APIs to enable both by-value and by-ref; I'd probably use something else that uses by-value forCopy
types and by-ref otherwise.