Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check runtime and compiled Godot versions for compatibility #512

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

Bromeon
Copy link
Member

@Bromeon Bromeon commented Nov 30, 2023

Related changes:

  • Remove legacy 4.0.x special case with patch == 999.
  • Fix UB with reading too far beyond function pointer.
  • Fix UB with reading entire struct at once.

@Bromeon Bromeon added quality-of-life No new functionality, but improves ergonomics/internals c: ffi Low-level components and interaction with GDExtension API labels Nov 30, 2023
@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-512

Related changes:
- Remove legacy 4.0.x special case with patch == 999.
- Fix UB with reading too far beyond function pointer.
- Fix UB with reading entire struct at once.
@Bromeon Bromeon force-pushed the qol/check-godot-version branch from a5f13ff to 5c9f898 Compare November 30, 2023 17:29
@Bromeon Bromeon enabled auto-merge November 30, 2023 17:29
@Bromeon Bromeon added this pull request to the merge queue Nov 30, 2023
Merged via the queue into master with commit 0b164ab Nov 30, 2023
@Bromeon Bromeon deleted the qol/check-godot-version branch November 30, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: ffi Low-level components and interaction with GDExtension API quality-of-life No new functionality, but improves ergonomics/internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants