Catch up with atom/node-spellchecker. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
We don't want to break compatibility with Node v8 just yet
Appveyor still does not support Node v12: appveyor/ci#2921
Fix builds with newer node.
- Introduce a new API call, `setSpellcheckerType` which takes a constant to determine if a system checker should be used, if available (the default), to always use the system checker, or to always use Hunspell. - Duplicates the specs to have a force to Hunspell implementation.
Add a new method, `setSpellcheckerType`, to pick spellchecker selection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.