-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go.mod to v5 #172
Update go.mod to v5 #172
Conversation
|
After I thought about this a little bit, I think we could safely change this to v5 and release under tag Running |
Let me know what the best course of action is here. |
Just so I'm clear, are you proposing using v5 instead of v6 in the .mod file and having me tag that as v5.0.2? If that is the case then that seems the right way to go. |
Would it be possible to get the v5 change/tag pushed soon? This currently breaks downstream consumers using go mod. |
@jsouthworth - Yes. v5 in the |
@bminer can you update the PR with v5. Then I'll merge and tag a release. |
Yes. Doing it now... |
Thanks @bminer, the release has now been tagged. |
Thank you, sir! |
Unfortunately, it looks like there is still something missing here. I set up a simple test and end up with:
This is probably because we have imports in the submodules that don't reference v5. |
@jsouthworth - Could be another submodule like you say, but you can always try |
Closes #125