Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert the project from setuptools -> poetry #52
Convert the project from setuptools -> poetry #52
Changes from 21 commits
6a431d8
480fb37
ce98c01
a1e3bc6
7a9c166
41b103c
bb0aa8b
fb49d10
8872ecd
dfd2856
4343813
3fd7634
ae6d7c6
2e3c72f
7e4c24c
e10e923
b12a23c
f0c8f30
ddc62fc
e987f57
1f9a2ad
d2bf668
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why we are going this route, rather than just using
poetry install
andpoetry build
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea here is that we ship a final image with none of the build artifacts; only the finally installed product. If you notice, poetry is not installed into the venv, and so doesn't actually get copied over to the final image. Same with the
-dev
packages installed on line 12. The main goal here is to provide as compact and clean an image as we can.So with all of that in mind, the easiest way to get Poetry to use the Python interpreter in the venv, is to do this export and pip install.
Of course, all this is adapted from a number of examples I've found online. So I'd be happy if somebody is able to help build a better way!
This file was deleted.
This file was deleted.