Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnqueueUniqueInByKey using secondsFromNow as TTL #222

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kh411d
Copy link

@kh411d kh411d commented Oct 6, 2022

I can't seem to understand whether this is intended or might be forgotten to modified the TTL key for EnqueueUniqueInByKey since this function is accepting secondsFromNow argument, kinda weird when we apply the secondsFromNow but the key expired in 24h, what if the dup happened after 24h and the job is still in the schedule?

If we look at the EnqueueUniqueByKey function, it makes sense if the key is expired in 24h since it's not scheduled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant