Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance and chores #169

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Maintenance and chores #169

wants to merge 7 commits into from

Conversation

ardhitama
Copy link

  • Add makefile to run sanity tests
  • Fix lint errors
  • Change the test redis namespace to use UUID to allow some tests to run in parallel
  • Update the mod and remove proven benches since the one of bench causing mod error

Copy link

@adamrt adamrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: Sorry I was trying to comment on 250fcba
@ardhitama I was just browsing these PR commits and noticed particular one.

Can you elaborate on why you changed this? It might affect people that already depend on this behavior.

Thanks

@ardhitama
Copy link
Author

Edit: Sorry I was trying to comment on 250fcba
@ardhitama I was just browsing these PR commits and noticed particular one.

Can you elaborate on why you changed this? It might affect people that already depend on this behavior.

Thanks

Thanks for noticing, this was to debug my particular need. Will remove this commit from the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants