Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty document should not panic on String() #630

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

bcho
Copy link
Contributor

@bcho bcho commented Jan 28, 2025

fixes #629

Before submitting your PR, please confirm the following.

  • Describe the purpose for which you created this PR.
  • Create test code that corresponds to the modification

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.36%. Comparing base (4f6cb1c) to head (b1de640).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #630   +/-   ##
=======================================
  Coverage   77.36%   77.36%           
=======================================
  Files          22       22           
  Lines        7885     7885           
=======================================
  Hits         6100     6100           
  Misses       1368     1368           
  Partials      417      417           

@goccy
Copy link
Owner

goccy commented Jan 31, 2025

Thank you for your contribution ! LGTM 👍

@goccy goccy merged commit 6f80c57 into goccy:master Jan 31, 2025
20 checks passed
@bcho bcho deleted the fix-empty-node branch January 31, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

String method call panics on empty document node
3 participants