Fix panic when parsing unattached comment #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parser panics when there's a comment without anything to attach it to. This PR fixes that case. Signed-off-by: Charith Ellawala <charith@cerbos.dev>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #565 +/- ##
=======================================
Coverage 77.45% 77.46%
=======================================
Files 21 21
Lines 7479 7482 +3
=======================================
+ Hits 5793 5796 +3
Misses 1291 1291
Partials 395 395 |
charithe
added a commit
to charithe/cerbos
that referenced
this pull request
Dec 2, 2024
Requires patch from goccy/go-yaml#565. Fixes cerbos#2401 Signed-off-by: Charith Ellawala <charith@cerbos.dev>
This was referenced Dec 2, 2024
goccy
reviewed
Dec 2, 2024
goccy
reviewed
Dec 2, 2024
goccy
requested changes
Dec 2, 2024
Signed-off-by: Charith Ellawala <charith@cerbos.dev>
Signed-off-by: Charith Ellawala <charith@cerbos.dev>
goccy
approved these changes
Dec 2, 2024
charithe
added a commit
to cerbos/cerbos
that referenced
this pull request
Dec 2, 2024
Requires patch from goccy/go-yaml#565. Fixes #2401 Signed-off-by: Charith Ellawala <charith@cerbos.dev> --------- Signed-off-by: Charith Ellawala <charith@cerbos.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the parser refactor, there's a panic when a comment exists on its own without anything to attach it to. This PR fixes that case.
Before submitting your PR, please confirm the following.