Introduce helpers (selectors) for anonymise all a subject's records. #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnbbrown
force-pushed
the
introduce-selectors
branch
from
d3c30ad to
eddb72f
Compare
DragosDumitrache
approved these changes
Mar 7, 2023
|
|
||
| describe ".anonymise_for!" do | ||
| let!(:model_b) do | ||
| klass.create!(first_name: "matt", last_name: "brown", company_name: "alpha") |
stephenbinns
reviewed
Mar 7, 2023
stephenbinns
reviewed
Mar 7, 2023
lib/anony/anonymisable.rb
Outdated
| # each of them. If a selector is not defined it will railse an exception. | ||
| def anonymise_for!(subject, subject_id) | ||
| anonymise_config. | ||
| select(subject, subject_id, &:anonymise!) |
There was a problem hiding this comment.
Is it worth double checking that each subject responds to anoynmise!?
There was a problem hiding this comment.
Can do - what behaviour would you expect? An error being raised?
There was a problem hiding this comment.
Something like this 70d18ab?
These can be used to anonymise all records that relate to a specific
subject.
You first define a block for a specific subject that returns a list of
anonymisable records.
```ruby
anonymise do
selectors do
for_subject(:user_id) { |user_id| self.select_for_user(user_id) }
end
end
```
This can then be used to anonymise all those subject using this API:
```ruby
ModelName.anonymise_for!(:user_id, "user_1234")
```
Attempting to use a selector that has not been defined will throw an
error.
mnbbrown
force-pushed
the
introduce-selectors
branch
from
eddb72f to
5b9d0f2
Compare
mnbbrown
force-pushed
the
introduce-selectors
branch
2 times, most recently
from
88b9da4 to
f5bb883
Compare
mnbbrown
force-pushed
the
introduce-selectors
branch
from
f5bb883 to
bbad3a0
Compare
Tabby
added a commit
that referenced
this pull request
Feb 20, 2024
Seems it wasn't updated for #97 either :/
Merged
Tabby
added a commit
that referenced
this pull request
Feb 20, 2024
Seems it wasn't updated for #97 either :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These can be used to anonymise all records that relate to a specific
subject.
You first define a block for a specific subject that returns a list of
anonymisable records.
You can also use scopes,
where, etc when defining your selectors:This can then be used to anonymise all those subject using this API:
If you attempt to anonymise records with a selector that has not been defined it will throw an error.