Add random number generation by mapping rand() to math/rand #819
Conversation
lara
force-pushed
the
random-number-gen
branch
2 times, most recently
from
b7ca140
to
9a09ecb
Compare
Codecov Report
@@ Coverage Diff @@
## master #819 +/- ##
==========================================
+ Coverage 81.00% 81.08% +0.07%
==========================================
Files 54 54
Lines 7413 7433 +20
==========================================
+ Hits 6005 6027 +22
+ Misses 1184 1182 -2
Partials 224 224
Continue to review full report at Codecov.
|
lara
force-pushed
the
random-number-gen
branch
2 times, most recently
from
15326da
to
137d2e9
Compare
| case 0: | ||
| return t.vm.initFloatObject(rand.Float64()) | ||
| case 1: | ||
| return t.vm.InitIntegerObject(rand.Intn(args[0].Value().(int))) |
There was a problem hiding this comment.
we probably should check arguments' types first. I think .(int) will make Go panicking when users pass something like a string.
… using math/rand Co-authored-by: Lara Aydin <ayd.dilara@gmail.com> Co-authored-by: Michael Grosser <michael@grosser.it>
|
@st0012 Sorry for the late turnaround, could you take a look again? I'd appreciate any tips for a simpler way to do safeguarding given 2 arguments at a time. |
…nd() is a non-integer
|
@lara thanks for the work, everything looks perfect now :-) Regarding the argument checks, I'm afraid there's no better way to do it atm. We did try adding some helpers to solve the issue, but that didn't work out too well. However, I will open a PR for spiking again in the following days. |
We're using
math/rand, because when we're later implementingsrand(), we need it to support seeding, whichcrypto/randdoes not provide.Fixes #810