Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix object_id method #796

Merged
merged 4 commits into from
Oct 27, 2019
Merged

Fix object_id method #796

merged 4 commits into from
Oct 27, 2019

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Oct 27, 2019

In the past, even if you call object_id on the exact same object, it returns different values every time. This PR is to fix that issue + some refactoring around object initialization functions.

vm/object.go Show resolved Hide resolved
vm/object.go Show resolved Hide resolved
vm/object.go Show resolved Hide resolved
vm/object.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 27, 2019

Codecov Report

Merging #796 into master will increase coverage by 0.02%.
The diff coverage is 87.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #796      +/-   ##
==========================================
+ Coverage   80.22%   80.24%   +0.02%     
==========================================
  Files          54       54              
  Lines        7399     7402       +3     
==========================================
+ Hits         5936     5940       +4     
+ Misses       1238     1237       -1     
  Partials      225      225
Impacted Files Coverage Δ
vm/decimal.go 94.64% <100%> (ø) ⬆️
vm/match_data.go 64.51% <100%> (ø) ⬆️
vm/error.go 70.96% <100%> (ø) ⬆️
vm/go_map.go 82.45% <100%> (ø) ⬆️
vm/float.go 80.91% <100%> (ø) ⬆️
vm/null.go 87.5% <100%> (ø) ⬆️
vm/integer.go 64.37% <100%> (ø) ⬆️
vm/boolean.go 93.33% <100%> (ø) ⬆️
vm/range.go 93.29% <100%> (ø) ⬆️
vm/regexp.go 75.51% <100%> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9074403...c0d21a3. Read the comment docs.

Copy link
Member

@64kramsystem 64kramsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm not 100% sure of the history policy - maybe the WIP could/should be removed from the commit 799884e before merging?

@st0012
Copy link
Member Author

st0012 commented Oct 27, 2019

@saveriomiroddi ah you're right, my bad 😕

@st0012
Copy link
Member Author

st0012 commented Oct 27, 2019

@saveriomiroddi updated, will merge after build finished

@st0012 st0012 merged commit 72ad103 into master Oct 27, 2019
@st0012 st0012 deleted the fix-object-id branch October 27, 2019 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants