-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix object_id method #796
Fix object_id method #796
Conversation
Codecov Report
@@ Coverage Diff @@
## master #796 +/- ##
==========================================
+ Coverage 80.22% 80.24% +0.02%
==========================================
Files 54 54
Lines 7399 7402 +3
==========================================
+ Hits 5936 5940 +4
+ Misses 1238 1237 -1
Partials 225 225
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm not 100% sure of the history policy - maybe the WIP
could/should be removed from the commit 799884e before merging?
@saveriomiroddi ah you're right, my bad 😕 |
@saveriomiroddi updated, will merge after build finished |
In the past, even if you call
object_id
on the exact same object, it returns different values every time. This PR is to fix that issue + some refactoring around object initialization functions.