Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dup #791

Merged
merged 8 commits into from
Oct 14, 2019
Merged

Implement dup #791

merged 8 commits into from
Oct 14, 2019

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Oct 13, 2019

The default dup method returns the receiver object. Mutable data structures like Object, Array, String and Hash have their own implementation to override the default behavior for real duplication.

@st0012 st0012 added this to the version 0.1.11 milestone Oct 13, 2019
@st0012 st0012 self-assigned this Oct 13, 2019
@codecov
Copy link

codecov bot commented Oct 13, 2019

Codecov Report

Merging #791 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #791      +/-   ##
==========================================
+ Coverage   80.22%   80.31%   +0.09%     
==========================================
  Files          54       54              
  Lines        7397     7431      +34     
==========================================
+ Hits         5934     5968      +34     
  Misses       1236     1236              
  Partials      227      227
Impacted Files Coverage Δ
vm/object.go 80.59% <100%> (+1.23%) ⬆️
vm/error.go 70.96% <100%> (ø) ⬆️
vm/array.go 96.17% <100%> (+0.05%) ⬆️
vm/class.go 85.8% <100%> (+0.17%) ⬆️
vm/string.go 98.27% <100%> (+0.01%) ⬆️
vm/hash.go 96.81% <100%> (+0.02%) ⬆️
vm/environment.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0fd347...3be37e8. Read the comment docs.

@st0012 st0012 modified the milestones: version 0.1.11, version 0.1.12 Oct 13, 2019
Copy link
Member

@64kramsystem 64kramsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@hachi8833 hachi8833 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the implementations!
I'll add the API docs to them.

@st0012 st0012 merged commit a97e245 into master Oct 14, 2019
@st0012 st0012 deleted the implement-dup branch October 14, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants