Add Result class #675
Merged
Add Result class #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Codecov Report
@@ Coverage Diff @@
## master #675 +/- ##
==========================================
+ Coverage 81.86% 81.86% +<.01%
==========================================
Files 57 57
Lines 7725 7727 +2
==========================================
+ Hits 6324 6326 +2
Misses 1132 1132
Partials 269 269
Continue to review full report at Codecov.
|
st0012
requested changes
May 24, 2018
.vscode/tasks.json
Outdated
| @@ -0,0 +1,18 @@ | |||
| { | |||
| // See https://go.microsoft.com/fwlink/?LinkId=733558 | |||
There was a problem hiding this comment.
Is it just me or these three line's background are different?
Also, I think we shouldn't put specific code editor's setting in the codebase. Is there any reason for this?
There was a problem hiding this comment.
Missed it. Will ad to the .gitignore
lib/option.gb
Outdated
| @@ -0,0 +1,29 @@ | |||
| class Option | |||
| def initialize(name=nil, value=nil) | |||
There was a problem hiding this comment.
can we make the indentation to 2 spaces?
| @@ -1204,8 +1204,10 @@ func builtinClassCommonInstanceMethods() []*BuiltinMethodObject { | |||
| loaders, ok := externalClasses[libName] | |||
| externalClassLock.Unlock() | |||
| if !ok { | |||
| return t.vm.InitErrorObject(errors.InternalError, sourceLine, "Can't require \"%s\"", libName) | |||
|
|
|||
| err := t.execGobyLib(libName + ".gb") | |||
st0012
approved these changes
May 28, 2018
|
This is a really nice addition @eliothedeman @st0012 😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Super basic implementation. Wasn't sure if it made sense to implement as a native go type or not though. #674